MS SQL Server support #3080
Merged
MS SQL Server support #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to missing batch functionality (see golang-migrate/migrate#756 & golang-migrate/migrate#666). Also added 2 missing drop index statements in the golang-migrate down scripts.
…x the "is not the same length or scale as referencing column" error. Also changed to docker imague due to a missing `sqlcmd` binary in the ARM image. Important: Make sure the varchar(36) is okay, and otherwise change referencing fields to use varchar(200) as well.
reinkrul
requested review from
gerardsn,
woutslakhorst,
JorisHeadease and
rolandgroen
|
All is green, anything specific to look at? |
woutslakhorst
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Test coverage is somewhat lacking, but DB-specific functionality is tested in the e2e test.